Skip to content

Conversation

@cyfyifanchen
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for ten-framework-portal ready!

Name Link
🔨 Latest commit df4d8b3
🔍 Latest deploy log https://app.netlify.com/projects/ten-framework-portal/deploys/6901e62135c32b000872f930
😎 Deploy Preview https://deploy-preview-166--ten-framework-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cyfyifanchen cyfyifanchen marked this pull request as draft October 22, 2025 08:16
@cyfyifanchen cyfyifanchen marked this pull request as ready for review October 29, 2025 10:02
@cyfyifanchen cyfyifanchen merged commit 18c87fd into TEN-framework:main Oct 29, 2025
3 of 4 checks passed
@cyfyifanchen cyfyifanchen deleted the 1022-workshop branch October 29, 2025 10:02
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +53 to +56
const envSnippet = [
'AGORA_APP_ID=d83b679bc7b3406c83f63864cb74aa99',
'DEEPSEEK_API_KEY=sk-61a43a61c84e45078a1ade4ef5113af0',
'DEEPGRAM_API_KEY=92366fdabbcc9da1013a3ed5ead4e6aa0c31173',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Do not publish real API keys in tutorial snippet

The new workshop page embeds concrete values for AGORA_APP_ID, DEEPSEEK_API_KEY and DEEPGRAM_API_KEY directly in the environment setup block. Because the page is rendered to end users, these tokens become public and can be abused or rotated unexpectedly, breaking the tutorial for everyone. These should be placeholders instructing attendees to supply their own credentials, not actual secrets checked into the repo.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant